slaesvuo/hledger
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop undecidable Ord instance for ParseError.

Browse Source 
That code fails to compile with ghc-8.6.1 because the instance is undecidable.
I suppose we could enable the appropriate compiler extension to support it, but
I've found that simply removing the instance causes no problems whatsoever: the
entire repository still compiles fine and it passes all test suites, too.
This commit is contained in:
Peter Simons 2018-10-24 12:26:14 +02:00 committed by Simon Michael
parent 4e8f2c11d3
commit 027d084878
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hledger-lib/Text/Megaparsec/Custom.hs
View File

@ -2,7 +2,6 @@
{-# LANGUAGE LambdaCase #-} {-# LANGUAGE LambdaCase #-}
{-# LANGUAGE PackageImports #-} {-# LANGUAGE PackageImports #-}
{-# LANGUAGE ScopedTypeVariables #-} {-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE StandaloneDeriving #-}
module Text.Megaparsec.Custom ( module Text.Megaparsec.Custom (
-- * Custom parse error type -- * Custom parse error type
@ -67,8 +66,6 @@ data CustomErr
-- derive it, but this requires an (orphan) instance for 'ParseError'. -- derive it, but this requires an (orphan) instance for 'ParseError'.
-- Hopefully this does not cause any trouble. -- Hopefully this does not cause any trouble.
deriving instance (Eq (Token c), Ord (Token c), Ord c, Ord e) => Ord (ParseError c e)
instance ShowErrorComponent CustomErr where instance ShowErrorComponent CustomErr where
showErrorComponent (ErrorFailAt _ _ errMsg) = errMsg showErrorComponent (ErrorFailAt _ _ errMsg) = errMsg
errorComponentLen (ErrorFailAt startOffset endOffset _) = errorComponentLen (ErrorFailAt startOffset endOffset _) =