fix -f option

Options.hs

@@ -8,18 +8,7 @@ import Data.Maybe (fromMaybe)
 import Utils
 
 
-data Flag = Version | File String | ShowSubs
+usageHeader = "Usage: hledger [OPTIONS] register|balance [MATCHARGS]"
-            deriving (Show,Eq)
-    
-options :: [OptDescr Flag]
-options = [
-            Option ['v'] ["version"] (NoArg Version)     "show version number"
-          , Option ['f'] ["file"]    (OptArg inp "FILE") "ledger file, or - to read stdin"
-          , Option ['s'] ["subtotal"] (NoArg ShowSubs)     "balance: show sub-accounts" --; register: show subtotals"
-          ]
-
-inp :: Maybe String -> Flag
-inp  = File . fromMaybe "stdin"
 
 getOptions :: [String] -> IO ([Flag], [String])
 getOptions argv =
@@ -27,17 +16,27 @@ getOptions argv =
       (o,n,[]  ) -> return (o,n)
       (_,_,errs) -> ioError (userError (concat errs ++ usageInfo usageHeader options))
 
-usageHeader = "Usage: hledger [OPTIONS] register|balance [MATCHARGS]"
+options :: [OptDescr Flag]
+options = [
+            Option ['v'] ["version"] (NoArg Version)     "show version number"
+          , Option ['f'] ["file"]    (OptArg readFileOpt "FILE") "ledger file, or - to read stdin"
+          , Option ['s'] ["subtotal"] (NoArg ShowSubs)     "balance: show sub-accounts" --; register: show subtotals"
+          ]
 
-get_content :: Flag -> Maybe String
+data Flag = Version | File String | ShowSubs deriving (Show,Eq)
-get_content (File s) = Just s
     
-defaultLedgerFile = "~/ledger.dat"
+readFileOpt :: Maybe String -> Flag
+readFileOpt  = File . fromMaybe "stdin"
     
-getLedgerFilePath :: IO String
+getFile :: Flag -> String
-getLedgerFilePath = do
+getFile (File s) = s
-  defaultpath <- tildeExpand defaultLedgerFile
+getFile _ = []
-  getEnv "LEDGER" `catch` \_ -> return defaultpath >>= return
+
+getLedgerFilePath :: [Flag] -> IO String
+getLedgerFilePath opts = do
+  defaultpath <- tildeExpand "~/ledger.dat"
+  envordefault <- getEnv "LEDGER" `catch` \_ -> return defaultpath
+  return $ last $ [envordefault] ++ (filter (/= "") (map getFile opts))
 
 -- ledger pattern args are a list of account patterns optionally followed
 -- by -- and a list of description patterns

hledger.hs

@@ -42,11 +42,11 @@ test = do
 
 register :: [Flag] -> [String] -> IO ()
 register opts args = do 
-  getLedgerFilePath >>= parseLedgerFile >>= doWithParsed (printRegister opts args)
+  getLedgerFilePath opts >>= parseLedgerFile >>= doWithParsed (printRegister opts args)
 
 balance :: [Flag] -> [String] -> IO ()
 balance opts args = do
-  getLedgerFilePath >>= parseLedgerFile >>= doWithParsed (printBalance opts args)
+  getLedgerFilePath opts >>= parseLedgerFile >>= doWithParsed (printBalance opts args)
 
 -- utils