From 5b27554f0af3ecb8658ad214ffceb44115313438 Mon Sep 17 00:00:00 2001 From: Simon Michael Date: Thu, 19 Jan 2023 20:57:02 -1000 Subject: [PATCH] dev: note why inferring costs from equity before balancing --- hledger-lib/Hledger/Read/Common.hs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hledger-lib/Hledger/Read/Common.hs b/hledger-lib/Hledger/Read/Common.hs index f873f63e8..e4bbfa385 100644 --- a/hledger-lib/Hledger/Read/Common.hs +++ b/hledger-lib/Hledger/Read/Common.hs @@ -325,6 +325,8 @@ journalFinalise iopts@InputOpts{..} f txt pj = do then journalAddAutoPostings _ioDay balancingopts_ -- Add auto postings if enabled, and account tags if needed else pure) >>= (if infer_costs_ then journalInferCostsFromEquity else pure) -- Maybe infer costs from equity postings where possible + -- XXX ^ You might think this should happen after journalBalanceTransactions, since filling in a missing amount can help + -- infer costs from equity. But currently ignoring excess inferred costs depends somehow on inferring them before balancing. >>= journalBalanceTransactions balancingopts_ -- Balance all transactions and maybe check balance assertions. <&> (if infer_equity_ then journalAddInferredEquityPostings else id) -- Maybe infer equity postings from costs where possible <&> journalInferMarketPricesFromTransactions -- infer market prices from commodity-exchanging transactions