From 5d9d9a8edb16a2e10c50a20188f09164c003d6b7 Mon Sep 17 00:00:00 2001
From: Simon Michael <simon@joyful.com>
Date: Mon, 20 Aug 2018 08:25:03 +0100
Subject: [PATCH] tests: drop obsolete helpers

---
 hledger-lib/Hledger/Utils/Test.hs | 33 +++++--------------------------
 1 file changed, 5 insertions(+), 28 deletions(-)

diff --git a/hledger-lib/Hledger/Utils/Test.hs b/hledger-lib/Hledger/Utils/Test.hs
index af4514d02..516fd8d0f 100644
--- a/hledger-lib/Hledger/Utils/Test.hs
+++ b/hledger-lib/Hledger/Utils/Test.hs
@@ -14,8 +14,6 @@ module Hledger.Utils.Test (
   ,_it
   ,expectParseEq
   ,expectParseEqOn
---  ,expectParseEq
---  ,expectParseEqOnIO
   -- * HUnit
   ,module Test.HUnit
   ,runHunitTests
@@ -100,39 +98,18 @@ expectEq' :: (Eq a, Show a, HasCallStack) => a -> a -> E.Test ()
 expectEq' x y = if x == y then E.ok else E.crash $
   "expected:\n" <> T.pack (pshow x) <> "\nbut got:\n" <> T.pack (pshow y) <> "\n"
 
--- XXX unnecessary ?
--- | Given a stateful, runnable-in-Identity-monad parser, input text, and 
+-- | Given a stateful parser runnable in IO, input text, and an 
 -- expected parse result, make a Test that parses the text and compares 
 -- the result, showing a nice failure message if either step fails.
---expectParseEq :: (Monoid st, Eq a, Show a, HasCallStack) => 
---  StateT st (ParsecT CustomErr T.Text Identity) a -> T.Text -> a -> E.Test ()
---expectParseEq parser input expected = expectParseEqOn parser input id expected
---
--- | Like expectParseEq, but also takes a transform function 
--- to call on the parse result before comparing it.
---expectParseEqOn :: (Monoid st, Eq b, Show b, HasCallStack) => 
---  StateT st (ParsecT CustomErr T.Text Identity) a -> T.Text -> (a -> b) -> b -> E.Test ()
---expectParseEqOn parser input f expected = do
---  let ep = runIdentity $ parseWithState mempty parser input
---  either (fail.("parse error at "++).parseErrorPretty) (expectEq' expected . f) ep
---
 expectParseEq :: (Monoid st, Eq a, Show a, HasCallStack) => 
   StateT st (ParsecT CustomErr T.Text IO) a -> T.Text -> a -> E.Test ()
-expectParseEq = expectParseEqIO
+expectParseEq parser input expected = expectParseEqOn parser input id expected
 
+-- | Like expectParseEq, but also takes a transform function 
+-- to call on the parse result before comparing it.
 expectParseEqOn :: (Monoid st, Eq b, Show b, HasCallStack) => 
   StateT st (ParsecT CustomErr T.Text IO) a -> T.Text -> (a -> b) -> b -> E.Test ()
-expectParseEqOn = expectParseEqOnIO
-
--- | Like expectParseEq, but takes a parser runnable in the IO monad.
-expectParseEqIO :: (Monoid st, Eq a, Show a, HasCallStack) => 
-  StateT st (ParsecT CustomErr T.Text IO) a -> T.Text -> a -> E.Test ()
-expectParseEqIO parser input expected = expectParseEqOnIO parser input id expected
-
--- | Like expectParseEqOn, but takes a parser runnable in the IO monad.
-expectParseEqOnIO :: (Monoid st, Eq b, Show b, HasCallStack) => 
-  StateT st (ParsecT CustomErr T.Text IO) a -> T.Text -> (a -> b) -> b -> E.Test ()
-expectParseEqOnIO parser input f expected = do
+expectParseEqOn parser input f expected = do
   ep <- E.io $ runParserT (evalStateT parser mempty) "" input
   either (fail.("parse error at "++).parseErrorPretty) (expectEq' expected . f) ep