From 656c779c6f72fa79ba5b7786f22068385d3129d0 Mon Sep 17 00:00:00 2001
From: Simon Michael <simon@joyful.com>
Date: Wed, 31 Dec 2025 12:49:44 -1000
Subject: [PATCH] ;workflows: rename nightly -> testbin

The nightly tag is no longer usable, having been used in a test of
immutable releases on Github. The branch/tag/workflow/release is
now "testbin", intended for publishing unreleased binaries for testing.
---
 .../workflows/{nightly.yml => testbin.yml}    | 10 +++---
 Justfile                                      | 34 +++++++------------
 doc/{ghnightlynotes.md => ghtestbinnotes.md}  |  4 +--
 3 files changed, 20 insertions(+), 28 deletions(-)
 rename .github/workflows/{nightly.yml => testbin.yml} (97%)
 rename doc/{ghnightlynotes.md => ghtestbinnotes.md} (91%)

diff --git a/.github/workflows/nightly.yml b/.github/workflows/testbin.yml
similarity index 97%
rename from .github/workflows/nightly.yml
rename to .github/workflows/testbin.yml
index 11b5dcc7c..a2ff56849 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/testbin.yml
@@ -1,8 +1,8 @@
 # TRIGGER: Runs when triggered manually.
-# ACTION: Uploads binaries from the latest successful binaries-* runs to the current "nightly" prerelease.
+# ACTION: Uploads binaries from the latest successful binaries-* runs to the current "testbin" prerelease.
 # Should not change anything else about the prerelease.
 
-name: nightly
+name: testbin
 
 on:
   workflow_dispatch:
@@ -125,18 +125,18 @@ jobs:
       run: |
         ls -lRFh artifacts
 
-    # The nightly prerelease should already exist; this should only update its artifacts.
+    # The testbin prerelease should already exist; this should only update its artifacts.
     # Alternative:
     # gh release upload {{ VER }} tmp/hledger-linux-x64.tar.gz
     # gh release upload {{ VER }} tmp/hledger-mac-arm64.tar.gz
     # gh release upload {{ VER }} tmp/hledger-mac-x64.tar.gz
     # gh release upload {{ VER }} tmp/hledger-windows-x64.zip
-    - name: Upload artifacts to nightly prerelease
+    - name: Upload artifacts to testbin prerelease
       uses: softprops/action-gh-release@69320dbe05506a9a39fc8ae11030b214ec2d1f87  # https://github.com/softprops/action-gh-release 2.0.5
       # permissions:
       #   contents: write
       with:
-        tag_name: nightly      
+        tag_name: testbin
         files: |
           artifacts/*.zip
           artifacts/*.tar.gz
diff --git a/Justfile b/Justfile
index b7b5b6af6..5423cfa34 100644
--- a/Justfile
+++ b/Justfile
@@ -1100,34 +1100,26 @@ devtag-push:
     echo "Pushing tag $DEVVER.."
     git push origin "$DEVVER"
 
-# XXX There's a tag and a github prerelease, both named nightly, creating confusion.
-# Try replacing the tag with a github nightly branch again.
-
-# # After release: point the nightly tag at the release and push the tag.
-# @nightlytag-push:
-#     git tag -f nightly $(just relver)
-#     git push -f origin nightly
-
-# Between releases: push HEAD to github nightly branch and start building new platform binaries.
-nightlybin:
+# Between releases: push HEAD to github testbin branch and start building new platform binaries.
+testbin:
     #!/usr/bin/env bash
     set -euo pipefail
-    git push -f origin HEAD:nightly
+    git push -f origin HEAD:testbin
     git push -f origin HEAD:binaries
-    printf "When binaries have built successfully, run:\n just nightlyrel-bin\n"
+    printf "When binaries have built successfully, run:\n just testbin-bin\n"
     just ghworkflows-open
 
-# Browse the github nightly prerelease.
-@nightlyrel-open:
-    gh release view -w nightly
+# Browse the github testbin prerelease.
+@testbin-open:
+    gh release view -w testbin
 
-# Push the nightly prerelease notes to the github nightly prerelease.
-@nightlyrel-notes:
-    gh release edit nightly -F doc/ghnightlynotes.md
+# Push the testbin prerelease notes to the github testbin prerelease.
+@testbin-notes:
+    gh release edit testbin -F doc/ghtestbinnotes.md
 
-# After building nightly binaries (nightlybin), copy them to the github nightly prerelease.
-@nightlyrel-bin:
-    gh workflow run nightly
+# After building testbin binaries (testbin), copy them to the github testbin prerelease.
+@testbin-bin:
+    gh workflow run testbin
 
 # ** Installing ------------------------------------------------------------
 INSTALLING:
diff --git a/doc/ghnightlynotes.md b/doc/ghtestbinnotes.md
similarity index 91%
rename from doc/ghnightlynotes.md
rename to doc/ghtestbinnotes.md
index 2c721649d..3caa5213a 100644
--- a/doc/ghnightlynotes.md
+++ b/doc/ghtestbinnotes.md
@@ -1,6 +1,6 @@
-Here you can find unreleased "nightly" binaries, which are updated occasionally. By using these and providing [feedback](https://hledger.org/support.html), you can help to make the next release better.
+Here you can find unreleased test binaries, which are updated occasionally. By using these and providing [feedback](https://hledger.org/support.html), you can help to make the next release better.
 
-These binaries have the following changes since the 1.51 release: https://github.com/simonmichael/hledger/compare/1.51...nightly
+These binaries have the following changes since the 1.51 release: https://github.com/simonmichael/hledger/compare/1.51...testbin
 
 <details>
 <summary>