;check: uniqueleafnames: short circuit to avoid wasted work

2021-01-09 18:59:10 -08:00 · 2021-01-09 18:59:10 -08:00 · 6931eec3ce
commit 6931eec3ce
parent b96713a584
1 changed files with 5 additions and 3 deletions
--- a/hledger/Hledger/Cli/Commands/Check/Uniqueleafnames.hs
+++ b/hledger/Hledger/Cli/Commands/Check/Uniqueleafnames.hs
@ -23,7 +23,9 @@ import Text.Printf (printf)
 journalCheckUniqueleafnames :: Journal -> Either String ()
 journalCheckUniqueleafnames j = do
  -- find all duplicate leafnames, and the full account names they appear in
-  let dupes = finddupes $ journalLeafAndFullAccountNames j
+  case finddupes $ journalLeafAndFullAccountNames j of
+    [] -> Right ()
+    dupes -> 
      -- report the first posting that references one of them (and its position), for now
      sequence_ $ map (checkposting dupes) $ journalPostings j