From 6e7b8f9862b8f094d9387a323d62c4e16b83d165 Mon Sep 17 00:00:00 2001
From: Simon Michael <simon@joyful.com>
Date: Sat, 18 May 2024 22:06:30 -1000
Subject: [PATCH] ;workflows: release: fixes

---
 .github/workflows/release.yml | 28 ++++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 24209f8fd..64de22d69 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -21,8 +21,8 @@ jobs:
 
     # Get artifact from the latest binaries-linux-x64 run
     - name: Get latest linux binaries artifact
-      # XXX unverified, disallowed
-      uses: dawidd6/action-download-artifact@09f2f74827fd3a8607589e5ad7f9398816f540fe  # https://github.com/dawidd6/action-download-artifact v3.1.4
+      uses: dawidd6/action-download-artifact@09f2f74827fd3a8607589e5ad7f9398816f540fe
+        # https://github.com/dawidd6/action-download-artifact v3.1.4, unverified so needs to be whitelisted in repo settings
       with:
         # Optional, GitHub token, a Personal Access Token with `public_repo` scope if needed
         # Required, if the artifact is from a different repo
@@ -50,9 +50,9 @@ jobs:
         # Optional, no need to specify if PR is
         # commit: ${{github.event.pull_request.head.sha}}
         # Optional, will use the specified branch. Defaults to all branches
-        branch: binaries-linux-x64
+        # branch: binaries-linux-x64
         # Optional, defaults to all types
-        event: push
+        # event: push
         # Optional, run number from the workflow
         # run_number: 34
         # Optional, uploaded artifact name,
@@ -66,7 +66,7 @@ jobs:
         # Optional, name is treated as a regular expression if set true
         # name_is_regexp: true
         # Optional, a directory where to extract artifact(s), defaults to the current directory
-        path: tmp
+        path: artifacts
         # Optional, defaults to current repo
         # repo: ${{ github.repository }}
         # Optional, check the workflow run to whether it has an artifact
@@ -85,14 +85,16 @@ jobs:
         # default fail
         # if_no_artifact_found: fail
         # Optional, allow forks when searching for artifacts
-        # default false
-        # allow_forks: false
+        # default true
+        allow_forks: false
 
     - name: Inspect
       shell: bash
       run: |
+        echo .:
         ls -lF
-        ls -lF tmp
+        echo artifacts:
+        ls -lRF artifacts
 
     # - name: Make tarball
     #   shell: bash
@@ -138,6 +140,16 @@ jobs:
 
 
 
+# https://github.com/marketplace/actions/safe-download-workflow-artifact
+
+# https://github.com/actions/upload-artifact/issues/89#issuecomment-1194408215
+
+# https://www.eliostruyf.com/retrieving-artifact-previous-github-actions-workflow/
+
+# We have two workflows, one for building and one for releasing built artifacts upon a tag release.
+# They're both summoned from one push event, and the release job waits for the other job:
+#  https://github.com/dawidd6/action-download-artifact/issues/245
+
 
     # - name: version
     #   run: echo "::set-output name=version::$(./bin/azblogfilter --version)"