From 7ffe38677acda587f4f947bb0bb8873190dfbefd Mon Sep 17 00:00:00 2001 From: Simon Michael Date: Wed, 25 Sep 2019 23:07:22 -1000 Subject: [PATCH] ;lib: parseAndFinaliseJournal: note txns order issue (#1091) --- hledger-lib/Hledger/Read/Common.hs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hledger-lib/Hledger/Read/Common.hs b/hledger-lib/Hledger/Read/Common.hs index 2ff8a8831..39098ae64 100644 --- a/hledger-lib/Hledger/Read/Common.hs +++ b/hledger-lib/Hledger/Read/Common.hs @@ -253,6 +253,13 @@ parseAndFinaliseJournal parser iopts f txt = do -- be false pending modifiers) and we don't reorder the second -- time. If we are only running once, we reorder and follow -- the options for checking assertions. + -- + -- TODO: since #903's refactoring for hledger 1.12, + -- journalApplyCommodityStyles here is seeing the + -- transactions before they get reversesd to normal order. + -- And this can trigger a bug in commodityStylesFromAmounts + -- (#1091). + -- let fj = if auto_ iopts && (not . null . jtxnmodifiers) pj -- transaction modifiers are active