slaesvuo/hledger
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: do haddock testing less often, in the mac binaries workflow

Browse Source 
It costs 1m+, doesn't fail that often, and is not hard to fix even if
detected late.
This commit is contained in:
Simon Michael 2023-11-07 05:27:18 -08:00
parent 617e35ec57
commit 96117ae514
2 changed files with 26 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.github/workflows/binaries-mac-x64.yml vendored
View File

@ -183,6 +183,18 @@ jobs:
COLUMNS=80 $stack exec -- shelltest --execdir -j16 hledger/test -x /_ -x /addons -x ledger-compat/ledger-baseline -x ledger-compat/ledger-regress -x ledger-compat/ledger-collected # bin COLUMNS=80 $stack exec -- shelltest --execdir -j16 hledger/test -x /_ -x /addons -x ledger-compat/ledger-baseline -x ledger-compat/ledger-regress -x ledger-compat/ledger-collected # bin
if: env.CONTINUE if: env.CONTINUE
# This is tested here rather than in the regular CI because it's slow,
# doesn't fail too often, and the cost of late detection and fixing is low.
- name: Test haddock generation
env:
stack: ${{ matrix.plan.stack }}
run: |
printf "haddock version: "; haddock --version
time $stack build --fast --haddock --no-haddock-deps --no-haddock-hyperlink-source --haddock-arguments="--no-print-missing-docs"
# --no-haddock-hyperlink-source is 25% faster
# --no-print-missing-docs is 600% quieter
if: env.CONTINUE
# artifacts: # artifacts:
- name: Gather binaries - name: Gather binaries

23
.github/workflows/ci.yml vendored
View File

@ -245,6 +245,7 @@ jobs:
# Packages are built one at a time to fail faster on error. # Packages are built one at a time to fail faster on error.
# Note: doctests won't run if using GHC 9.0, see hledger-lib/package.yaml # Note: doctests won't run if using GHC 9.0, see hledger-lib/package.yaml
# Takes ~2m on a 2023 github worker.
- name: Build all hledger modules fast, warning free, run unit/doc/bench tests - name: Build all hledger modules fast, warning free, run unit/doc/bench tests
env: env:
stack: ${{ matrix.plan.stack }} stack: ${{ matrix.plan.stack }}
@ -267,6 +268,7 @@ jobs:
shelltest --version shelltest --version
if: env.CONTINUE if: env.CONTINUE
# Takes ~30s on a 2023 github worker.
- name: Test functional tests (excluding addons) - name: Test functional tests (excluding addons)
env: env:
stack: ${{ matrix.plan.stack }} stack: ${{ matrix.plan.stack }}
@ -276,15 +278,18 @@ jobs:
# XXX run the bin/ func tests corresponding to the GHC version enabled above, only # XXX run the bin/ func tests corresponding to the GHC version enabled above, only
if: env.CONTINUE if: env.CONTINUE
- name: Test haddock generation # Takes 1m+ on a 2023 github worker.
env: # Moved to (one of) the binaries-* workflows instead;
stack: ${{ matrix.plan.stack }} # haddock breakage might not be found until release time but it's easy to fix.
run: | # - name: Test haddock generation
printf "haddock version: "; haddock --version # env:
time $stack build --fast --haddock --no-haddock-deps --no-haddock-hyperlink-source --haddock-arguments="--no-print-missing-docs" || echo "HADDOCK FAILED, IGNORING" # stack: ${{ matrix.plan.stack }}
# --no-haddock-hyperlink-source is 25% faster # run: |
# --no-print-missing-docs is 600% quieter # printf "haddock version: "; haddock --version
if: env.CONTINUE # time $stack build --fast --haddock --no-haddock-deps --no-haddock-hyperlink-source --haddock-arguments="--no-print-missing-docs" || echo "HADDOCK FAILED, IGNORING"
# # --no-haddock-hyperlink-source is 25% faster
# # --no-print-missing-docs is 600% quieter
# if: env.CONTINUE
- name: Gather binaries - name: Gather binaries
id: exes id: exes