slaesvuo/hledger
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib: better message when roi fails to value commodity, fixes #1446

Browse Source
This commit is contained in:
Dmitry Astapov 2021-01-12 02:12:00 +00:00 committed by Simon Michael
parent 1023a3cc1a
commit 9869624c5c
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hledger/Hledger/Cli/Commands/Roi.hs
View File

@ -263,6 +263,6 @@ total trans query = unMix $ sumPostings $ filter (matchesPosting query) $ conca
unMix :: MixedAmount -> Quantity
unMix a =
case (normaliseMixedAmount $ mixedAmountCost a) of
(Mixed [a]) -> aquantity a
_ -> error' "MixedAmount failed to normalize" -- PARTIAL:
case (unifyMixedAmount $ mixedAmountCost a) of
Just a -> aquantity a
Nothing -> error' $ "Amounts could not be converted to a single cost basis: " ++ show (map showAmount $ amounts a)

15
hledger/test/roi.test
View File

@ -225,3 +225,18 @@ hledger -f- roi -p 2019-11
+---++------------+------------++---------------+----------+-------------+-----++-------+-------+
>>>=0
# 9. Fail with a nice error message when commodity can't be valued
hledger -f- roi -p 2019-11 --inv Investment --pnl PnL
<<<
2019/11/01 Example
Assets:Checking -1 A
Investment 10 B
2019/11/02 Example
Investment -10 B @@ 1 A
Assets:Checking 12 A
Unrealized PnL
>>>2
hledger: Amounts could not be converted to a single cost basis: ["10 B","-10 B @@ 1 A"]
>>>=1