From ab1e1760108f4b3aeeb2ebe3940eb2f02cf5cfc6 Mon Sep 17 00:00:00 2001
From: Saku Laesvuori <saku@laesvuori.fi>
Date: Sun, 25 Jan 2026 22:43:42 +0200
Subject: [PATCH] Fix transaction visibility without add permission

---
 hledger-web/templates/journal.hamlet | 146 +++++++++++++--------------
 1 file changed, 73 insertions(+), 73 deletions(-)

diff --git a/hledger-web/templates/journal.hamlet b/hledger-web/templates/journal.hamlet
index 6ecbce3f4..d9905136c 100644
--- a/hledger-web/templates/journal.hamlet
+++ b/hledger-web/templates/journal.hamlet
@@ -6,82 +6,82 @@ $if elem AddPermission perms
      data-toggle="modal" data-target="#addmodal" title="Lisää uusi tapahtuma kirjanpitoon.">
     Kirjaa tapahtuma
 
-  <ol .transactionsreport .list-unstyled>
-    $forall torig <- items
-      <li .transaction ##{transactionFrag torig}>
-        <div .title title="#{showTransaction torig}">
-          $with (payee, note) <- payeeAndNoteFromDescription' $ tdescription torig
-            <details .elided-text .transaction-metarow>
+<ol .transactionsreport .list-unstyled>
+  $forall torig <- items
+    <li .transaction ##{transactionFrag torig}>
+      <div .title title="#{showTransaction torig}">
+        $with (payee, note) <- payeeAndNoteFromDescription' $ tdescription torig
+          <details .elided-text .transaction-metarow>
+            <summary>
+              <time .date datetime="#{show (tdate torig)}" nowrap>
+                #{show (tdate torig)}
+              <div .status>
+                $case tstatus torig
+                  $of Unmarked
+                    <div .status-unmarked title="Tarkistamaton" aria-label="Tarkistamaton">
+                  $of Pending
+                    <div .status-pending title="Kesken" aria-label="Kesken">
+                  $of Cleared
+                    <div .status-cleared title="Tarkistettu" aria-label="Tarkistettu">
+              $if not $ T.null $ tcode torig
+                <div .transaction-code>
+                  <a href=@?{addCodeQuery $ tcode torig} .filter>
+                    (#{tcode torig})
+              $if not $ T.null $ T.strip payee
+                <span .transaction-payee>
+                  <a href=@?{addPayeeQuery payee} .filter>
+                    #{payee}
+          $if not $ T.null $ T.strip note
+            <details .transaction-note .elided-text>
               <summary>
-                <time .date datetime="#{show (tdate torig)}" nowrap>
-                  #{show (tdate torig)}
-                <div .status>
-                  $case tstatus torig
-                    $of Unmarked
-                      <div .status-unmarked title="Tarkistamaton" aria-label="Tarkistamaton">
-                    $of Pending
-                      <div .status-pending title="Kesken" aria-label="Kesken">
-                    $of Cleared
-                      <div .status-cleared title="Tarkistettu" aria-label="Tarkistettu">
-                $if not $ T.null $ tcode torig
-                  <div .transaction-code>
-                    <a href=@?{addCodeQuery $ tcode torig} .filter>
-                      (#{tcode torig})
-                $if not $ T.null $ T.strip payee
-                  <span .transaction-payee>
-                    <a href=@?{addPayeeQuery payee} .filter>
-                      #{payee}
-            $if not $ T.null $ T.strip note
-              <details .transaction-note .elided-text>
-                <summary>
-                  #{note}
+                #{note}
 
-          $if null $ filter isVisibleTag $ ttags torig
-          $else
-            <ul .tags>
-              $forall (tagName, tagValue) <- filter isVisibleTag $ ttags torig
-                <li .tag title="#{mconcat [tagName, ": ", tagValue]}">
-                  <div .tag-name>
-                    <a href=@?{addTagQuery tagName tagValue} .filter>
-                      #{tagName}
-                  $if not $ T.null $ T.strip tagValue
-                    <div .tag-value>
-                      $if isAbsoluteURI tagValue
-                        <a href="#{tagValue}">#{tagValue}
-                      $elseif tagName == "tosite"
-                        <a href="@{documentRoute tagValue}">#{tagValue}
-                      $else
-                        #{tagValue}
+        $if null $ filter isVisibleTag $ ttags torig
+        $else
+          <ul .tags>
+            $forall (tagName, tagValue) <- filter isVisibleTag $ ttags torig
+              <li .tag title="#{mconcat [tagName, ": ", tagValue]}">
+                <div .tag-name>
+                  <a href=@?{addTagQuery tagName tagValue} .filter>
+                    #{tagName}
+                $if not $ T.null $ T.strip tagValue
+                  <div .tag-value>
+                    $if isAbsoluteURI tagValue
+                      <a href="#{tagValue}">#{tagValue}
+                    $elseif tagName == "tosite"
+                      <a href="@{documentRoute tagValue}">#{tagValue}
+                    $else
+                      #{tagValue}
 
-        <ul .postings>
-          $forall Posting { paccount = acc, pamount = amt, pbalanceassertion = passert, ptags = tags } <- tpostings torig
-            <li .posting>
-              <div .posting-row>
-                <div .account>
-                  <a href="@?{acctlink acc}##{tindex torig}" title="#{acc}">
-                    #{elideAccountName 40 acc}
-                <div .amount style="text-align:right;">
-                  <span .posted-amount>
-                    ^{mixedAmountAsHtml amt}
-                  $maybe BalanceAssertion { baamount = assertAmt } <- passert
-                    <span .balance-assertion>
-                      jälkeen ^{mixedAmountAsHtml $ mixedAmount assertAmt}
-              $if null $ filter (isPostingTag acc) $ filter isVisibleTag tags
-              $else
-                <ul .tags>
-                  $forall (tagName, tagValue) <- filter (isPostingTag acc) $ filter isVisibleTag tags
-                    <li .tag title="#{mconcat [tagName, ": ", tagValue]}">
-                      <div .tag-name>
-                        <a href=@?{addTagQuery tagName tagValue} .filter>
-                          #{tagName}
-                      $if not $ T.null $ T.strip tagValue
-                        <div .tag-value>
-                          $if isAbsoluteURI tagValue
-                            <a href="#{tagValue}">#{tagValue}
-                          $elseif tagName == "tosite"
-                            <a href="@{documentRoute tagValue}">#{tagValue}
-                          $else
-                            #{tagValue}
+      <ul .postings>
+        $forall Posting { paccount = acc, pamount = amt, pbalanceassertion = passert, ptags = tags } <- tpostings torig
+          <li .posting>
+            <div .posting-row>
+              <div .account>
+                <a href="@?{acctlink acc}##{tindex torig}" title="#{acc}">
+                  #{elideAccountName 40 acc}
+              <div .amount style="text-align:right;">
+                <span .posted-amount>
+                  ^{mixedAmountAsHtml amt}
+                $maybe BalanceAssertion { baamount = assertAmt } <- passert
+                  <span .balance-assertion>
+                    jälkeen ^{mixedAmountAsHtml $ mixedAmount assertAmt}
+            $if null $ filter (isPostingTag acc) $ filter isVisibleTag tags
+            $else
+              <ul .tags>
+                $forall (tagName, tagValue) <- filter (isPostingTag acc) $ filter isVisibleTag tags
+                  <li .tag title="#{mconcat [tagName, ": ", tagValue]}">
+                    <div .tag-name>
+                      <a href=@?{addTagQuery tagName tagValue} .filter>
+                        #{tagName}
+                    $if not $ T.null $ T.strip tagValue
+                      <div .tag-value>
+                        $if isAbsoluteURI tagValue
+                          <a href="#{tagValue}">#{tagValue}
+                        $elseif tagName == "tosite"
+                          <a href="@{documentRoute tagValue}">#{tagValue}
+                        $else
+                          #{tagValue}
 
 $if elem AddPermission perms
   ^{addModal AddR j today}