diff --git a/hledger-lib/Hledger/Read/CsvReader.hs b/hledger-lib/Hledger/Read/CsvReader.hs index c957865ab..747c92138 100644 --- a/hledger-lib/Hledger/Read/CsvReader.hs +++ b/hledger-lib/Hledger/Read/CsvReader.hs @@ -46,7 +46,12 @@ reader sep = Reader {rFormat = Sep sep ,rExtensions = [show sep] ,rReadFn = parse sep - ,rParser = error' "sorry, CSV files can't be included yet" -- PARTIAL: + ,rParser = fail "sorry, CSV files can't be included yet" -- PARTIAL: + -- This unnecessarily shows the CSV file's first line in the error message, + -- but gives a more useful message than just calling error'. + -- XXX Note every call to error' in Hledger.Read.* is potentially a similar problem - + -- the error message is good enough when the file was specified directly by the user, + -- but not good if it was loaded by a possibly long chain of include directives. } -- | Parse and post-process a "Journal" from CSV data, or give an error. diff --git a/hledger/test/errors/csvnoinclude.test b/hledger/test/errors/csvnoinclude.test index eb04bb3c0..1eca09bf6 100644 --- a/hledger/test/errors/csvnoinclude.test +++ b/hledger/test/errors/csvnoinclude.test @@ -1,4 +1,3 @@ $$$ hledger check -f csvnoinclude.j ->>>2 /Error: sorry, CSV files can't be included yet -/ +>>>2 /CSV files can't be included yet/ >>>= 1