From c63d85c81fe2dd172c088fa2c82e8543d62d99ae Mon Sep 17 00:00:00 2001 From: Simon Michael Date: Thu, 29 May 2025 13:39:13 -1000 Subject: [PATCH] ;ci:binaries: cleanups, notes --- .github/workflows/_binaries-windows-arm64.yml | 1 + .github/workflows/binaries-linux-x64.yml | 4 +++- .github/workflows/binaries-mac-arm64.yml | 4 ++-- .github/workflows/binaries-mac-x64.yml | 5 +++-- .github/workflows/binaries-windows-x64.yml | 21 ++++++++++--------- 5 files changed, 20 insertions(+), 15 deletions(-) diff --git a/.github/workflows/_binaries-windows-arm64.yml b/.github/workflows/_binaries-windows-arm64.yml index d12ab4dbd..ed6ae594a 100644 --- a/.github/workflows/_binaries-windows-arm64.yml +++ b/.github/workflows/_binaries-windows-arm64.yml @@ -25,6 +25,7 @@ jobs: # caching + # XXX Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. - name: Cache - stack programs dir # ghc, ghc-included packages and their haddocks, mingw, msys2 id: stack-programs-dir uses: actions/cache@v4 diff --git a/.github/workflows/binaries-linux-x64.yml b/.github/workflows/binaries-linux-x64.yml index d6f5211c2..d91cfcd31 100644 --- a/.github/workflows/binaries-linux-x64.yml +++ b/.github/workflows/binaries-linux-x64.yml @@ -34,6 +34,7 @@ jobs: restore-keys: | ${{ runner.os }}-ghcup + # XXX Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. - name: Cache - ~/.cabal id: cabal uses: actions/cache@v4 @@ -102,7 +103,8 @@ jobs: # upload-artifact loses execute permissions, so we tar the binaries to preserve them. # github UI always zips artifacts when they are downloaded, so we don't bother compressing the tar. - # Unfortunately it means users must both unzip and untar. + # https://github.com/actions/upload-artifact?tab=readme-ov-file#limitations + # In release workflows, we repack these using the platform's native compression scheme. - name: Upload binaries uses: actions/upload-artifact@v4 with: diff --git a/.github/workflows/binaries-mac-arm64.yml b/.github/workflows/binaries-mac-arm64.yml index 265327bc9..eefab2fd5 100644 --- a/.github/workflows/binaries-mac-arm64.yml +++ b/.github/workflows/binaries-mac-arm64.yml @@ -120,7 +120,7 @@ jobs: - name: Install shelltestrunner run: | export PATH=~/.local/bin:$PATH - if [[ ! -x ~/.local/bin/shelltest ]]; then $stack install shelltestrunner-1.10; fi + if [[ ! -x ~/.local/bin/shelltest ]]; then $stack install --verbosity=error shelltestrunner; fi shelltest --version - name: Test functional tests (excluding addons) @@ -162,8 +162,8 @@ jobs: # upload-artifact loses execute permissions, so we tar the binaries to preserve them. # github UI always zips artifacts when they are downloaded, so we don't bother compressing the tar. - # Unfortunately it means users must both unzip and untar. # https://github.com/actions/upload-artifact?tab=readme-ov-file#limitations + # In release workflows, we repack these using the platform's native compression scheme. - name: Upload binaries artifact uses: actions/upload-artifact@v4 with: diff --git a/.github/workflows/binaries-mac-x64.yml b/.github/workflows/binaries-mac-x64.yml index 4e88a8c75..23a483e09 100644 --- a/.github/workflows/binaries-mac-x64.yml +++ b/.github/workflows/binaries-mac-x64.yml @@ -120,7 +120,7 @@ jobs: - name: Install shelltestrunner run: | export PATH=~/.local/bin:$PATH - if [[ ! -x ~/.local/bin/shelltest ]]; then $stack install shelltestrunner-1.10; fi + if [[ ! -x ~/.local/bin/shelltest ]]; then $stack install --verbosity=error shelltestrunner; fi shelltest --version - name: Test functional tests (excluding addons) @@ -153,7 +153,8 @@ jobs: # upload-artifact loses execute permissions, so we tar the binaries to preserve them. # github UI always zips artifacts when they are downloaded, so we don't bother compressing the tar. - # Unfortunately it means users must both unzip and untar. + # https://github.com/actions/upload-artifact?tab=readme-ov-file#limitations + # In release workflows, we repack these using the platform's native compression scheme. - name: Upload binaries artifact uses: actions/upload-artifact@v4 with: diff --git a/.github/workflows/binaries-windows-x64.yml b/.github/workflows/binaries-windows-x64.yml index 55836ca51..2856dbb27 100644 --- a/.github/workflows/binaries-windows-x64.yml +++ b/.github/workflows/binaries-windows-x64.yml @@ -25,16 +25,17 @@ jobs: # caching - - name: Cache - stack programs dir # ghc, ghc-included packages and their haddocks, mingw, msys2 - id: stack-programs-dir - uses: actions/cache@v4 - with: - path: C:\Users\runneradmin\AppData\Local\Programs\stack\ - # which files signal a change in stack's global db ? - # **.yaml includes */package.yaml and stack.yaml* (too many), and hopefully no other changing yamls - key: ${{ runner.os }}-appdata-local-programs-stack-${{ hashFiles('**.yaml') }} - restore-keys: | - ${{ runner.os }}-appdata-local-programs-stack + # Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. + # - name: Cache - stack programs dir # ghc, ghc-included packages and their haddocks, mingw, msys2 + # id: stack-programs-dir + # uses: actions/cache@v4 + # with: + # path: C:\Users\runneradmin\AppData\Local\Programs\stack\ + # # which files signal a change in stack's global db ? + # # **.yaml includes */package.yaml and stack.yaml* (too many), and hopefully no other changing yamls + # key: ${{ runner.os }}-appdata-local-programs-stack-${{ hashFiles('**.yaml') }} + # restore-keys: | + # ${{ runner.os }}-appdata-local-programs-stack - name: Cache - stack global dir id: stack-global-package-db