From c72970834315f24dcbbadb0ca1016924e3571f7a Mon Sep 17 00:00:00 2001 From: Vladimir Zhelezov Date: Fri, 11 Dec 2020 07:20:12 +0100 Subject: [PATCH] Refactor _hledger_extension_completion_function() Reduce number of instructions, remove variables used only once --- shell-completion/hledger-completion.bash | 8 ++------ shell-completion/hledger-completion.bash.m4 | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/shell-completion/hledger-completion.bash b/shell-completion/hledger-completion.bash index a0542aca4..0b627ca1a 100644 --- a/shell-completion/hledger-completion.bash +++ b/shell-completion/hledger-completion.bash @@ -90,15 +90,11 @@ _hledger_completion_function() { } _hledger_extension_completion_function() { - local cmd=$1 - shift - # Change parameters and arguments and call the # normal hledger completion function. - local extensionName=${cmd#*-} - COMP_WORDS=( "hledger" "$extensionName" "${COMP_WORDS[@]:1}" ) + COMP_WORDS=("hledger" "${1#*-}" "${COMP_WORDS[@]:1}") COMP_CWORD=$((COMP_CWORD + 1)) - _hledger_completion_function "hledger" "$@" + _hledger_completion_function "hledger" "${@:1}" } # Register completion function for hledger: diff --git a/shell-completion/hledger-completion.bash.m4 b/shell-completion/hledger-completion.bash.m4 index 7ae4ae850..ed5aa7009 100644 --- a/shell-completion/hledger-completion.bash.m4 +++ b/shell-completion/hledger-completion.bash.m4 @@ -90,15 +90,11 @@ _hledger_completion_function() { } _hledger_extension_completion_function() { - local cmd=$1 - shift - # Change parameters and arguments and call the # normal hledger completion function. - local extensionName=${cmd#*-} - COMP_WORDS=( "hledger" "$extensionName" "${COMP_WORDS[@]:1}" ) + COMP_WORDS=("hledger" "${1#*-}" "${COMP_WORDS[@]:1}") COMP_CWORD=$((COMP_CWORD + 1)) - _hledger_completion_function "hledger" "$@" + _hledger_completion_function "hledger" "${@:1}" } # Register completion function for hledger: