From ca4fc4a421bd83dbcf90b586c609fb68eaa3ffa5 Mon Sep 17 00:00:00 2001
From: Simon Michael <simon@joyful.com>
Date: Mon, 6 Apr 2020 18:18:01 -0700
Subject: [PATCH] web: add form: drop unneeded C-minus/C-plus keys & related
 help text

---
 hledger-web/static/hledger.js         | 23 +++++++++--------------
 hledger-web/templates/add-form.hamlet |  4 ----
 2 files changed, 9 insertions(+), 18 deletions(-)

diff --git a/hledger-web/static/hledger.js b/hledger-web/static/hledger.js
index 4e39e0cc0..0dd8b2197 100644
--- a/hledger-web/static/hledger.js
+++ b/hledger-web/static/hledger.js
@@ -33,7 +33,7 @@ $(document).ready(function() {
   $('body').bind('keydown', 'a',       function(){ addformShow(); return false; });
   $('body').bind('keydown', 'n',       function(){ addformShow(); return false; });
   $('body').bind('keydown', 'f',       function(){ $('#searchform input').focus(); return false; });
-  addformBindKeys();
+  lastAmountBindKey();
 
   // highlight the entry from the url hash
   if (window.location.hash && $(window.location.hash)[0]) {
@@ -48,14 +48,8 @@ $(document).ready(function() {
   });
 });
 
-// Set up keybindings affecting the add form, everywhere they should be
-// (body, each add form input, and one more on the last amount input).
-// Called on page load and again each time an add form row is added.
-function addformBindKeys() {
-  $('body, #addform input, #addform select').bind('keydown', 'ctrl++',       addformAddPosting);
-  $('body, #addform input, #addform select').bind('keydown', 'ctrl+shift+=', addformAddPosting);
-  $('body, #addform input, #addform select').bind('keydown', 'ctrl+=',       addformAddPosting);
-  $('body, #addform input, #addform select').bind('keydown', 'ctrl+-',       addformDeletePosting);
+// Add the add-new-row-on-keypress handler to the current last amount field.
+function lastAmountBindKey() {
   $('.amount-input:last').keypress(addformAddPosting);
 }
 
@@ -175,7 +169,7 @@ function addformAddPosting() {
     return;
   }
 
-  // Remove the add-new-row-on-keypress handler from the old last amount field
+  // Remove the keypress handler from the old last amount field
   $('.amount-input:last').off('keypress');
 
   // Clone the old last row to make a new last row
@@ -184,8 +178,9 @@ function addformAddPosting() {
   var n = $('#addform .account-group').length;
   $('.account-input:last').prop('placeholder', 'Account '+n).val('');
   $('.amount-input:last').prop('placeholder','Amount '+n).val('');  // XXX Enable typehead on dynamically created inputs
-  // and ensure they have the proper keybindings
-  addformBindKeys();
+
+  // and add the keypress handler to the new last amount field
+  lastAmountBindKey();
 }
 
 // Remove the add form's last posting row, if empty, keeping at least two.
@@ -202,8 +197,8 @@ function addformDeletePosting() {
   if (focuslost) {
     focus($('.account-input:last'));
   }
-  // Rebind keypress
-  $('.amount-input:last').keypress(addformAddPosting);
+
+  lastAmountBindKey();
 }
 
 //----------------------------------------------------------------------
diff --git a/hledger-web/templates/add-form.hamlet b/hledger-web/templates/add-form.hamlet
index b4197b8e6..1ad394ecb 100644
--- a/hledger-web/templates/add-form.hamlet
+++ b/hledger-web/templates/add-form.hamlet
@@ -65,7 +65,3 @@ $if length journals > 1
       $forall p <- journals
         <option value=#{p}>#{p}
 <span .small style="padding-left:2em;">
-  Enter a value in the last field for #
-  <a href="#" onclick="addformAddPosting(); return false;">
-    more
-  \ (or ctrl +, ctrl -)