dev: fix warnings, update yaml file, edit [#2340]

hledger-lib/Hledger/Utils/IO.hs

@@ -429,8 +429,7 @@ hasOutputFile = do
 -- in some places, it's not guaranteed to work)
 --
 -- In any case, $LINES/$COLUMNS should not be used as a source for the terminal
--- size -- that is a bashism, and in particular they aren't updated as the
+-- size - they are not available or do not update reliably in all shells.
--- terminal is resized.
 --
 -- See #2332 for details
 

hledger/Hledger/Cli/CliOptions.hs

@@ -94,7 +94,7 @@ import Data.Char
 import Data.Default
 import Data.Either (isRight)
 import Data.List.Extra (groupSortOn, intercalate, isInfixOf, nubSort)
-import qualified Data.List.NonEmpty as NE (NonEmpty, fromList, head, nonEmpty)
+import qualified Data.List.NonEmpty as NE (NonEmpty, fromList, nonEmpty)
 import Data.List.Split (splitOn)
 import Data.Maybe
 --import Data.String.Here
@@ -107,7 +107,6 @@ import String.ANSI
 import System.Console.CmdArgs hiding (Default,def)
 import System.Console.CmdArgs.Explicit
 import System.Console.CmdArgs.Text
-import Hledger.Utils.IO (getTerminalWidth)
 import System.Directory
 import System.Environment
 import System.Exit (exitSuccess)

hledger/package.yaml

@@ -92,10 +92,6 @@ extra-source-files:
 #data-files:
 
 flags:
-  terminfo:
-    description: On POSIX systems, build with the terminfo lib for detecting terminal width
-    default: true
-    manual:  false
   threaded:
     description: Build with support for multithreaded execution
     default: true
@@ -158,9 +154,6 @@ dependencies:
 - wizards >=1.0
 
 when:
-- condition: (!(os(windows))) && (flag(terminfo))
-  dependencies:
-  - terminfo
 - condition: (flag(debug))
   cpp-options: -DDEBUG
 # - condition: (flag(ghcdebug))