diff --git a/hledger-lib/Hledger/Query.hs b/hledger-lib/Hledger/Query.hs index ca7d52c8d..701cf8069 100644 --- a/hledger-lib/Hledger/Query.hs +++ b/hledger-lib/Hledger/Query.hs @@ -579,19 +579,6 @@ matchesAccount (Depth d) a = accountNameLevel a <= d matchesAccount (Tag _ _) _ = False matchesAccount _ _ = True --- | Total version of matchesAccount, which will return any error --- arising from a malformed regular expression in the query. - -- FIXME: unnecssary --- matchesAccount_ :: Query -> AccountName -> Either RegexError Bool --- matchesAccount_ (None) _ = Right False --- matchesAccount_ (Not m) a = Right $ not $ matchesAccount m a --- matchesAccount_ (Or ms) a = sequence (map (`matchesAccount_` a) ms) >>= pure . or --- matchesAccount_ (And ms) a = sequence (map (`matchesAccount_` a) ms) >>= pure . and --- matchesAccount_ (Acct r) a = match r (T.unpack a) -- XXX pack --- matchesAccount_ (Depth d) a = Right $ accountNameLevel a <= d --- matchesAccount_ (Tag _ _) _ = Right False --- matchesAccount_ _ _ = Right True - matchesMixedAmount :: Query -> MixedAmount -> Bool matchesMixedAmount q (Mixed []) = q `matchesAmount` nullamt matchesMixedAmount q (Mixed as) = any (q `matchesAmount`) as @@ -600,13 +587,6 @@ matchesCommodity :: Query -> CommoditySymbol -> Bool matchesCommodity (Sym r) = match r . T.unpack matchesCommodity _ = const True --- | Total version of matchesCommodity, which will return any error --- arising from a malformed regular expression in the query. - -- FIXME unnecessary --- matchesCommodity_ :: Query -> CommoditySymbol -> Bool --- matchesCommodity_ (Sym r) = match r . T.unpack --- matchesCommodity_ _ = const True - -- | Does the match expression match this (simple) amount ? matchesAmount :: Query -> Amount -> Bool matchesAmount (Not q) a = not $ q `matchesAmount` a @@ -618,19 +598,6 @@ matchesAmount (Amt ord n) a = compareAmount ord n a matchesAmount (Sym r) a = matchesCommodity (Sym r) (acommodity a) matchesAmount _ _ = True --- | Total version of matchesAmount, returning any error from a --- malformed regular expression in the query. - -- FIXME Unnecessary --- matchesAmount_ :: Query -> Amount -> Either RegexError Bool --- matchesAmount_ (Not q) a = not <$> q `matchesAmount_` a --- matchesAmount_ (Any) _ = Right True --- matchesAmount_ (None) _ = Right False --- matchesAmount_ (Or qs) a = sequence (map (`matchesAmount_` a) qs) >>= pure . or --- matchesAmount_ (And qs) a = sequence (map (`matchesAmount_` a) qs) >>= pure . and --- matchesAmount_ (Amt ord n) a = Right $ compareAmount ord n a --- matchesAmount_ (Sym r) a = matchesCommodity_ (Sym r) (acommodity a) --- matchesAmount_ _ _ = Right True - -- | Is this simple (single-amount) mixed amount's quantity less than, greater than, equal to, or unsignedly equal to this number ? -- For multi-amount (multiple commodities, or just unsimplified) mixed amounts this is always true. @@ -677,32 +644,6 @@ matchesPosting (Tag n v) p = case (reString n, v) of ("note", Just v) -> maybe False (match v . T.unpack . transactionNote) $ ptransaction p (_, v) -> matchesTags n v $ postingAllTags p --- | Total version of matchesPosting, returning any error from a --- malformed regular expression in the query. - -- -- FIXME: unnecessary --- matchesPosting_ :: Query -> Posting -> Bool --- matchesPosting_ (Not q) p = not <$> q `matchesPosting_` p --- matchesPosting_ (Any) _ = Right True --- matchesPosting_ (None) _ = Right False --- matchesPosting_ (Or qs) p = sequence (map (`matchesPosting_` p) qs) >>= pure.or --- matchesPosting_ (And qs) p = sequence (map (`matchesPosting_` p) qs) >>= pure.and --- matchesPosting_ (Code r) p = match r $ maybe "" (T.unpack . tcode) $ ptransaction p --- matchesPosting_ (Desc r) p = match r $ maybe "" (T.unpack . tdescription) $ ptransaction p --- matchesPosting_ (Acct r) p = sequence [matches p, matches (originalPosting p)] >>= pure.or --- where matches p = match r $ T.unpack $ paccount p -- XXX pack --- matchesPosting_ (Date span) p = Right $ span `spanContainsDate` postingDate p --- matchesPosting_ (Date2 span) p = Right $ span `spanContainsDate` postingDate2 p --- matchesPosting_ (StatusQ s) p = Right $ postingStatus p == s --- matchesPosting_ (Real v) p = Right $ v == isReal p --- matchesPosting_ q@(Depth _) Posting{paccount=a} = q `matchesAccount_` a --- matchesPosting_ q@(Amt _ _) Posting{pamount=amt} = Right $ q `matchesMixedAmount` amt --- matchesPosting_ (Empty _) _ = Right True --- matchesPosting_ (Sym r) Posting{pamount=Mixed as} = sequence (map (matchesCommodity_ (Sym r)) $ map acommodity as) >>= pure.or --- matchesPosting_ (Tag n v) p = case (n, v) of --- ("payee", Just v) -> maybe (Right False) (T.unpack . transactionPayee >>> match v) $ ptransaction p --- ("note", Just v) -> maybe (Right False) (T.unpack . transactionNote >>> match v) $ ptransaction p --- (n, v) -> matchesTags_ n v $ postingAllTags p - -- | Does the match expression match this transaction ? matchesTransaction :: Query -> Transaction -> Bool matchesTransaction (Not q) t = not $ q `matchesTransaction` t @@ -726,31 +667,6 @@ matchesTransaction (Tag n v) t = case (reString n, v) of ("note", Just v) -> match v . T.unpack . transactionNote $ t (_, v) -> matchesTags n v $ transactionAllTags t --- | Total version of matchesTransaction, returning any error from a --- malformed regular expression in the query. - -- FIXME: unnecessary --- matchesTransaction_ :: Query -> Transaction -> Either RegexError Bool --- matchesTransaction_ (Not q) t = not <$> q `matchesTransaction_` t --- matchesTransaction_ (Any) _ = Right True --- matchesTransaction_ (None) _ = Right False --- matchesTransaction_ (Or qs) t = sequence (map (`matchesTransaction_` t) qs) >>= pure.or --- matchesTransaction_ (And qs) t = sequence (map (`matchesTransaction_` t) qs) >>= pure.and --- matchesTransaction_ (Code r) t = match r $ T.unpack $ tcode t --- matchesTransaction_ (Desc r) t = match r $ T.unpack $ tdescription t --- matchesTransaction_ q@(Acct _) t = sequence (map (q `matchesPosting_`) $ tpostings t) >>= pure.or --- matchesTransaction_ (Date span) t = Right $ spanContainsDate span $ tdate t --- matchesTransaction_ (Date2 span) t = Right $ spanContainsDate span $ transactionDate2 t --- matchesTransaction_ (StatusQ s) t = Right $ tstatus t == s --- matchesTransaction_ (Real v) t = Right $ v == hasRealPostings t --- matchesTransaction_ q@(Amt _ _) t = sequence (map (q `matchesPosting_`) $ tpostings t) >>= pure.or --- matchesTransaction_ (Empty _) _ = Right True --- matchesTransaction_ (Depth d) t = sequence (map (Depth d `matchesPosting_`) $ tpostings t) >>= pure.or --- matchesTransaction_ q@(Sym _) t = sequence (map (q `matchesPosting_`) $ tpostings t) >>= pure.or --- matchesTransaction_ (Tag n v) t = case (n, v) of --- ("payee", Just v) -> match v . T.unpack . transactionPayee $ t --- ("note", Just v) -> match v . T.unpack . transactionNote $ t --- (n, v) -> matchesTags_ n v $ transactionAllTags t - -- | Does the query match the name and optionally the value of any of these tags ? matchesTags :: Regexp -> Maybe Regexp -> [Tag] -> Bool matchesTags namepat valuepat = not . null . filter (matches namepat valuepat) @@ -768,19 +684,6 @@ matchesPriceDirective q@(Sym _) p = matchesCommodity q (pdcommodity p) matchesPriceDirective (Date span) p = spanContainsDate span (pddate p) matchesPriceDirective _ _ = True --- | Total version of matchesPriceDirective, returning any error from --- a malformed regular expression in the query. - -- FIXME unnecessary --- matchesPriceDirective_ :: Query -> PriceDirective -> Either RegexError Bool --- matchesPriceDirective_ (None) _ = Right False --- matchesPriceDirective_ (Not q) p = not <$> matchesPriceDirective_ q p --- matchesPriceDirective_ (Or qs) p = sequence (map (`matchesPriceDirective_` p) qs) >>= pure.or --- matchesPriceDirective_ (And qs) p = sequence (map (`matchesPriceDirective_` p) qs) >>= pure.and --- matchesPriceDirective_ q@(Amt _ _) p = matchesAmount_ q (pdamount p) --- matchesPriceDirective_ q@(Sym _) p = matchesCommodity_ q (pdcommodity p) --- matchesPriceDirective_ (Date span) p = Right $ spanContainsDate span (pddate p) --- matchesPriceDirective_ _ _ = Right True - -- tests diff --git a/hledger-lib/Hledger/Utils/Regex.hs b/hledger-lib/Hledger/Utils/Regex.hs index 3ffa35105..d21a88358 100644 --- a/hledger-lib/Hledger/Utils/Regex.hs +++ b/hledger-lib/Hledger/Utils/Regex.hs @@ -215,7 +215,6 @@ replaceRegexUnmemo_ re repl s = foldM (replaceMatch_ repl) s (reverse $ match (r -- The replacement text: the replacement pattern with all -- numeric backreferences replaced by the appropriate groups -- from this match. Or an error message. - -- FIXME: Use makeRegex instead of toRegex_ erepl = replaceAllByM backrefRegex (lookupMatchGroup_ matchgroups) replpat where -- Given some match groups and a numeric backreference,