e0fab4f882
SMorgan:
This PR aims to accomplish two major goals:
- Get boring parent ellision working for multiBalanceReport
- Remove the special BalanceReport code, and just use multiBalanceReport
I believe it does both, with the following additional benefits:
A refactor of multiBalanceReportWith, to make the structure easier to follow, and with a clearer division of responsibilities
All decisions for how an account name is to be displayed are now made in multiBalanceReport, rather than scattered around the code base
Some miscellaneous improvements in account name rendering, including --drop now working with MultiBalanceReports, and addressing some of #373
Algorithmic changes:
- Using HashMap AccountName (Map DateSpan Account) instead of [[MixedAmount]] is new. I admit I didn't profile this change (though given the nubs and lookups, I thought it was appropriate), so I'm glad it produces a speedup.
- Producing the starting balances no longer calls the whole balanceReport, just the first few functions to get what it needs.
- displayedAccounts is completely rewritten. Perhaps one subtle thing to note is that in tree mode it no longer excludes nodes with zero inclusive balance unless they also have zero exclusive balance.
SMichael:
I'll mark the passing of the old multiBalanceReport, into which I poured many an hour :). It is in a way the heart (brain ?) of hledger - the key feature of ledgerlikes (balance report) and a key improvement introduced by hledger (tabular multiperiod balance reports). You have split that 300-line though well documented function into modular parts, which could be a little harder to understand in detail but are easier to understand in the large and more amenable to further refactoring. Then you fixed some old limitations (boring parent eliding in multi period balance reports, --drop with tree mode reports), allowing us to drop the old balanceReport and focus on just the new multiBalanceReport. And for representing the tabular data you replaced the semantically correct but inefficient list of lists with a map of maps, speeding up many-columned balance reports significantly (~40%). Last and not least you made it really easy to review. Thanks @Xitian9, great work.
|
||
|---|---|---|
| .github | ||
| .sandstorm | ||
| bin | ||
| checks | ||
| doc | ||
| docker | ||
| examples | ||
| hledger | ||
| hledger-install | ||
| hledger-lib | ||
| hledger-ui | ||
| hledger-web | ||
| shell-completion | ||
| tests | ||
| tools | ||
| .appveyor.yml | ||
| .ci | ||
| .ctags | ||
| .dockerignore | ||
| .editorconfig | ||
| .ghci | ||
| .gitignore | ||
| .hlint.yaml | ||
| .mailmap | ||
| .travis.yml | ||
| .version | ||
| azure-pipelines.yml | ||
| bench.sh | ||
| cabal.project | ||
| CHANGES.md | ||
| CONTRIBUTING.md | ||
| CREDITS.md | ||
| dev.hs | ||
| Dockerfile | ||
| LICENSE | ||
| Makefile | ||
| Makefile.helpsys | ||
| README.md | ||
| ROADMAP.md | ||
| Shake.hs | ||
| stack7.10.yaml.disabled | ||
| stack8.0.yaml | ||
| stack8.2.yaml | ||
| stack8.4.yaml | ||
| stack8.6.yaml | ||
| stack8.10.yaml | ||
| stack.yaml | ||
hledger project README
lightweight, portable, dependable accounting tools
hledger is a computer program for easily tracking money, time, or other commodities, on unix, mac and windows (and web-capable mobile devices, to some extent).
It is first a command-line tool, but there are also terminal and web interfaces, and a Haskell library for building your own programs and scripts (hledger is written in Haskell). hledger was inspired by and is largely compatible with Ledger. hledger is free software available under the GNU General Public License v3+.
hledger aims to help both computer experts and regular folks to gain clarity and control in their finances and time management, but currently it is a bit more suited to techies. I use it every day to:
- track spending and income
- see time reports by day/week/month/project
- get accurate numbers for client billing and tax filing
- track invoices
Though limited in features, hledger is lightweight, usable and reliable. For some, it is a simpler, less distracting, more future-proof alternative to Quicken or GnuCash.
For more, see the home page: https://hledger.org
Sponsorship
Your support, large or small, helps keep this project strong!
See also https://hledger.org#sponsorship.
Sponsor Simon (project leader): 
Sponsor the hledger project as an organisation: 
Sponsor the hledger project as an individual: 
Bounties for specific tasks: 
Obligatory Badges
